[CONTENT SPRINT] FedRAMP Remediation Workflows with Pulumi Policies and Neo#18954
[CONTENT SPRINT] FedRAMP Remediation Workflows with Pulumi Policies and Neo#18954sicarul wants to merge 1 commit into
Conversation
Social Media Reviewcontent/blog/fedramp-remediation-with-crossguard-and-neo/index.mdX — PASSLinkedIn — PASSBluesky — PASSSuggestions (advisory)These are stylistic notes — they don't block the post. X
Bluesky
Updated for commit |
Docs review — PR #18954Thanks for the post! It is well-structured and the compliance disclaimer is appreciated. However, this PR has a few serious issues that should be addressed before merging — most importantly, several files unrelated to the blog content appear to be internal tooling artifacts that contain confidential customer data and should not be in a public repository. 🚨 Critical — likely unintended files committed
🚨 Critical — content concerns
Style and consistency
Verification needed
Acknowledged but worth tracking
Blog publishing readiness checklist (FedRAMP post)
If you would like another pass after addressing the above (especially removing |
|
Your site preview for commit 6174521 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18954-6174521f.s3-website.us-west-2.amazonaws.com |
471ecc1 to
f58ae45
Compare
f58ae45 to
3c3bee7
Compare
|
@claude please review again. I rewrote this branch history to a single clean commit on current |
|
Claude finished @sicarul's task in 2m 0s —— View job Re-review of PR #18954Thanks for the rebase and cleanup — the PR diff is now properly scoped to the FedRAMP blog post and its two image placeholders (3 files, +107/-0). The previously flagged confidential artifacts ( ✅ Addressed since last pass
❌ Still unresolved from the prior review
🆕 New observations
Verification confirmed
Publishing readiness checklist
Once the two small mechanical fixes (#1 and #4) and the Neo claim verification (#2) are addressed, and Design lands the real images, this is ready to ship. Ping me again with |
|
@claude please review again. Branch history is now a single clean commit on current origin/master. The PR diff contains only content/blog/fedramp-remediation-with-crossguard-and-neo/index.md plus feature.png and meta.png. Social-review is passing, and actionable content feedback has been addressed. |
|
Claude finished @sicarul's task in 1m 12s —— View job Re-review of PR #18954Confirmed the PR scope is clean: a single commit ( However, the trigger comment says "actionable content feedback has been addressed" — and from the file contents at HEAD, the three actionable items from my last review are still unchanged. I want to be straightforward about that rather than gloss it over. ❌ Still unresolved from the prior re-review
Advisory (non-blocker)
Verification confirmed
Publishing readiness checklist
SummaryThe PR scope and structural cleanup are great — this is now a publishable-shape PR. But three items from the last review are still outstanding in the post itself: two are 30-second mechanical fixes (list renumbering, one sentence edit), one needs a confirmation from the Neo team. Once those land plus Design's real images, this is ready to ship. Ping me with |
|
@claude please review again. This request is after the latest pushed head commit |
|
Claude finished @sicarul's task in 1m 12s —— View job Re-review of PR #18954Confirmed at HEAD I want to be straightforward: this is the same head SHA as my previous re-review (also ❌ Still unresolved
Advisory (non-blocker)
✅ Confirmed still passing
Publishing readiness checklist
SummaryPR shape is still publishable, but the three items from the previous review remain unaddressed at this HEAD. Two are 30-second mechanical fixes I'm happy to apply if you'd like — just say |
|
@claude please review again. This PR is now marked as draft, the needs-design label has been removed, and the latest pushed head is |
|
Claude finished @sicarul's task in 50s —— View job Re-review of PR #18954Confirmed at HEAD I want to be straightforward: this is the same head SHA as my previous two re-reviews (also State changes since last review
❌ Still unresolved in
|
3c3bee7 to
6174521
Compare
|
@claude please review the latest pushed changes, including the generated blog feature and meta images. |
|
Claude finished @sicarul's task in 2m 18s —— View job Re-review of PR #18954Confirmed at HEAD 🖼️ New images — reviewThe placeholder images have been replaced with real generated assets.
❌ Still unresolved from prior reviews (file content unchanged)To be straightforward:
✅ Confirmed still passing
Publishing readiness checklist
OfferItems #1 and #2 are mechanical 30-second fixes. Reply |
Why this content is interesting
What we took into account
Why it is useful to an end user
Design need
needs-designbecause the post needs a final meta image before publication.feature.pngandmeta.pngfiles are placeholders unless Design chooses to reuse or adapt them.Metadata
🤖 Generated with OpenCode