[CONTENT SPRINT] Snowflake Warehouses, Roles, and Short-Lived Credentials with Pulumi#18952
[CONTENT SPRINT] Snowflake Warehouses, Roles, and Short-Lived Credentials with Pulumi#18952sicarul wants to merge 1 commit into
Conversation
Social Media Reviewcontent/blog/pulumi-snowflake-warehouses-roles-esc/index.mdX — PASSLinkedIn — PASSBluesky — PASSSuggestions (advisory)These are stylistic notes — they don't block the post. X
Bluesky
Updated for commit |
|
Your site preview for commit 7fc80c2 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18952-7fc80c2a.s3-website.us-west-2.amazonaws.com |
Lighthouse Performance ReportCommit: ea7f6c0 | Metric definitions
|
ea7f6c0 to
760b02c
Compare
760b02c to
8ebe386
Compare
|
@claude please review again. I rewrote this branch history to a single clean commit on current |
|
Claude finished @sicarul's task in 1m 38s —— View job Re-reviewThanks for the cleanup — the rewrite landed correctly. The PR now shows a single commit ( What looks good
Suggestions (non-blocking)
VerdictContent is solid and the structural issues from the previous review are resolved. The two items I'd actually act on before merge are (a) verifying
|
|
@claude please review again. Branch history is now a single clean commit on current origin/master. The PR diff contains only content/blog/pulumi-snowflake-warehouses-roles-esc/index.md plus feature.png and meta.png. Social-review is passing, and actionable content feedback has been addressed. |
|
Claude finished @sicarul's task in 1m 8s —— View job Re-reviewPR is now scoped exactly to the three blog files under What looks good
Outstanding items from previous reviewThese two were called out in the prior pass and remain unaddressed in
Non-blocking notes (unchanged from last pass)
VerdictThe structural cleanup landed correctly and social-review is passing. The only must-fix before merge is the line-54 heading case. The
|
|
@claude please review again. This request is after the latest pushed head commit |
|
Claude finished @sicarul's task in 1m 40s —— View job Re-reviewPR scope is clean — single commit
|
|
@claude please review again. This PR is now marked as draft, the needs-design label has been removed, and the latest pushed head is |
|
Claude finished @sicarul's task in 1m 10s —— View job Re-reviewConfirmed: head commit is The file content is byte-identical to the prior re-review — so the two items I flagged last time are still outstanding. Calling them out below so they don't get lost when this comes out of draft. Still outstanding from prior reviews
What looks good (unchanged)
Notes on the status changes
VerdictSame as prior pass: line 54 heading case is the one hard style-guide blocker;
|
8ebe386 to
7fc80c2
Compare
|
@claude please review the latest pushed changes, including the generated blog feature and meta images. |
|
Claude finished @sicarul's task in 1m 54s —— View job Re-reviewHead is now ImagesBoth PNGs are properly sized ( However: both images pair the Snowflake logo with an AWS logo, and the post body never mentions AWS. The post is purely about Snowflake + Pulumi + Pulumi ESC; the ESC example uses
If this was a deliberate choice (e.g., the canonical Pulumi ESC OIDC flow assumes AWS as the trust provider), worth a one-line mention in the prose to make the image legible. Still outstanding from prior reviewsThe content of
What looks good (unchanged)
VerdictThe regenerated images are a clear visual improvement over placeholders, but the AWS logo without any AWS content in the body is a mismatch that's worth resolving before publish. The two text-level items from prior reviews (line 54 heading case,
|
Why this content is interesting
What we took into account
Why it is useful to an end user
Design need
needs-designbecause the post needs a final meta image before publication.feature.pngandmeta.pngfiles are placeholders unless Design chooses to reuse or adapt them.Metadata
🤖 Generated with OpenCode