ci: validate pulumi/esc-action fix (pin to 197ccaa)#18927
ci: validate pulumi/esc-action fix (pin to 197ccaa)#18927borisschlosser wants to merge 2 commits into
Conversation
The pulumi/esc-action v1 tag was moved today (2026-05-13) to a commit that includes pulumi/esc-action#35 ("Add missing inputs"), which declared oidc-auth as an explicit input with default: 'false' in action.yml. The action's getInput helper is: const val = core.getInput(name) || process.env[`ESC_ACTION_${envVar}`]; Now that core.getInput('oidc-auth') returns the non-empty string 'false' by default, the env-var fallback never fires and OIDC is silently disabled. esc then falls back to PULUMI_ACCESS_TOKEN, which isn't set, and every CI job using the ESC_ACTION_OIDC_AUTH env-var pattern fails: Error: could not determine current cloud: PULUMI_ACCESS_TOKEN must be set for login during non-interactive CLI sessions Pass oidc-auth: true explicitly on each invocation so the input value wins regardless of the action's default. Only oidc-auth needs this — the other oidc-* inputs default to '' (falsy), so the env-var fallback still works for them. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Docs reviewScope: 24 GitHub Actions workflow files modified to add Verification of fix completeness
Suggestions (non-blocking)
Other notes
VerdictLGTM as a CI hotfix. The two suggestions above are housekeeping, not blockers. Mention me (@claude) if you'd like another pass or want me to take a stab at the |
|
Your site preview for commit b36d585 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18927-b36d585c.s3-website.us-west-2.amazonaws.com |
Validates the upstream fix in pulumi/esc-action@197ccaa ("Fix oidc-auth default breaking ESC_ACTION_OIDC_AUTH env-var fallback") by: - Pinning every esc-action invocation to that exact SHA, and - Removing the `with: oidc-auth: true` workaround added in the previous commit on this branch. If CI passes, it proves the upstream fix restores the env-var fallback path on its own — no consumer-side workaround needed. Once the v1 tag is moved to include the fix, we can revert to pulumi/esc-action@v1. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Pushed v1 tag in esc-action repo which includes the actual fix: pulumi/esc-action#43 |
Summary
Validates the upstream fix in pulumi/esc-action@197ccaa ("Fix oidc-auth default breaking ESC_ACTION_OIDC_AUTH env-var fallback", from pulumi/esc-action#43, fixes pulumi/esc-action#42) by pinning every esc-action invocation in this repo to that exact SHA.
A green CI on this PR is the validation signal: if jobs authenticate successfully against the pinned SHA without any consumer-side workaround, the upstream fix is working.
Background
The
pulumi/esc-actionv1tag was moved on 2026-05-13 ~02:26 UTC (when pulumi/esc-action#41 landed) to a commit that included an earlier regression from pulumi/esc-action#35 —oidc-authwas declared inaction.ymlwithdefault: 'false'.The action's input/env helper is:
Once
core.getInput('oidc-auth')started returning the non-empty string'false'by default, the|| process.env[...]fallback never fired — silently disabling OIDC for every consumer that configured the action via theESC_ACTION_OIDC_AUTH=trueenv-var pattern.escthen errored out with:This broke every open PR (#18925, #18923, #18920, ...) and scheduled jobs.
The upstream fix changes the
oidc-authdefault inaction.ymlfrom'false'to'', matching the otheroidc-*inputs, socore.getInputreturns falsy and the env-var fallback works again.What this PR does
with: oidc-auth: trueon every invocation) to unblock CI immediately.pulumi/esc-action@v1reference to@197ccaa42ab49560ce838a3010eb8345ce086896so this PR's CI exercises only the upstream fix.24 workflow files updated; all 30 workflow YAML files parse OK.
Follow-up
Once the
v1tag is moved to include the fix, swap the pinned SHA back to@v1in a follow-up PR.Test plan
pull-request.yml,build-and-deploy.yml,pulumi-cli.yml, andesc-cli.ymlshow the pinned SHA and nowith:blocks on esc-action steps@v1🤖 Generated with Claude Code