Skip to content

Replace Airflow with Astro role for CloudFront logs bucket access#17054

Merged
sicarul merged 2 commits intomasterfrom
dwh/replace-airflow-with-astro-role
Jan 14, 2026
Merged

Replace Airflow with Astro role for CloudFront logs bucket access#17054
sicarul merged 2 commits intomasterfrom
dwh/replace-airflow-with-astro-role

Conversation

@sicarul
Copy link
Copy Markdown
Contributor

@sicarul sicarul commented Jan 14, 2026

The data warehouse is migrating from Airflow to Astro. Update the bucket policy to reference the Astro role instead of the Airflow task role for cross-account S3 access to CloudFront logs.

The data warehouse is migrating from Airflow to Astro. Update the
bucket policy to reference the Astro role instead of the Airflow
task role for cross-account S3 access to CloudFront logs.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Jan 14, 2026

Review Summary

This PR cleanly updates the infrastructure code to migrate from Airflow to Astro for data warehouse access to CloudFront logs. The changes are consistent and complete.

✅ What looks good

  • Complete refactoring: All references to Airflow have been successfully replaced with Astro throughout the file
  • Consistent naming: Variable names follow clear conventions (astroAwsRoleArn, astroStack, astroRole)
  • Stack reference updated: Correctly points to the new stack reference pulumi/dwh-workflows-orchestrate-astro/production
  • Comments updated: Code comments accurately reflect the Astro migration
  • Functionality preserved: The bucket policy logic remains unchanged, only the role reference has been updated
  • No orphaned references: Verified that no Airflow references remain in the file

✅ No issues found

The changes are straightforward, well-executed, and ready to merge. The migration maintains the same access patterns while pointing to the new Astro infrastructure.


If you would like me to review anything else or make additional changes, mention me (@claude) in a comment.

@pulumi-bot
Copy link
Copy Markdown
Collaborator

@pulumi-bot
Copy link
Copy Markdown
Collaborator

@sicarul sicarul enabled auto-merge (squash) January 14, 2026 05:21
@sicarul sicarul requested a review from lucascrespo88 January 14, 2026 15:36
Copy link
Copy Markdown

@lucascrespo88 lucascrespo88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sicarul sicarul merged commit 6aeb13d into master Jan 14, 2026
8 checks passed
@sicarul sicarul deleted the dwh/replace-airflow-with-astro-role branch January 14, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants