Conversation
Documentation ReviewI've reviewed the PR and found the following issues that need to be addressed: Critical Issues1. Missing meta image (content/blog/pulumi-cloud-iam-self-hosted/index.md:6) The frontmatter references 2. Incorrect documentation links (content/blog/pulumi-cloud-iam-self-hosted/index.md:53-56) The documentation links point to Current (incorrect): - [Overview](/docs/pulumi-cloud/access-management/rbac)
- [Roles](/docs/pulumi-cloud/access-management/rbac/roles)
- [Permissions](/docs/pulumi-cloud/access-management/rbac/permissions)
- [Scopes](/docs/pulumi-cloud/access-management/rbac/scopes)Should be: 3. Missing trailing newline (data/team/team/davide-massarenti.toml:6) The file must end with a newline character per repository conventions. Minor IssuesStyle observation (content/blog/pulumi-cloud-iam-self-hosted/index.md:30-32) The bullet points use asterisks ( Positive Notes
Please address the critical issues (missing meta image, incorrect doc links, and missing trailing newline) before merging. Mention @claude if you'd like me to review the changes again or help with any fixes. |
|
@arunkumar611 needs a meta image unless we want to reuse the original one. Not sure what source we are using to create those! |
Co-authored-by: Meagan <50200557+meagancojocar@users.noreply.github.com>
Co-authored-by: arunkumar611 <arunkloganathan@gmail.com>
Co-authored-by: arunkumar611 <arunkloganathan@gmail.com>
Co-authored-by: arunkumar611 <arunkloganathan@gmail.com>
|
Documentation Review: I have reviewed PR 17045 and found the content to be well-written and properly formatted. Style compliance is good with proper heading case. All internal links are valid and properly aliased. File ends with a newline as required. Front matter has all required fields. Product naming is correct. Minor suggestions: Line 32 could add a period after etc for consistency. Line 37 could change powerful to especially valuable. Line 45 could use the arrow symbol instead of dash-greater-than for navigation paths per the style guide. Overall the blog post is well-crafted and ready for publication. The suggestions are minor polish items. Need additional reviews? Mention @claude in a comment. |
|
Your site preview for commit 1df5251 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17045-1df52511.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 20b3370 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17045-20b33700.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 9733872 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17045-9733872d.s3-website.us-west-2.amazonaws.com. |
Proposed changes
Adds a blog entry announcing self-hosted support for Pulumi IAM.