Refactor Mocktail file handling to be encapsulated by the MocktailResponse class #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extracted and exposed mocktail response creation. This allows the file format to be used with other approaches to stubbing out web services for testing, such as registering handlers with GCDWebServer for example. * - Created mocktail response initializer and limited access to default initializer which is not very useful by itself
* Take an error pointer in MocktailResponse and handle the result outside of the MocktailResponse class * Add constants for the user data in MocktailResponse errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MocktailResponseclass Mocktail files can be reused for purposes other than running Mocktail. Whether that be generating other types of network responses, pulling out values for unit testing, or something else entirely.