Skip to content

Conversation

@glisignoli
Copy link

Fixes #209

Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition!

@glisignoli glisignoli force-pushed the 209_deb_repository_default_remote branch from 705373c to 6c5a5bf Compare July 21, 2025 20:44
@glisignoli
Copy link
Author

@mdellweg thank you for your review. I have made the suggested changes.

Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really have the remote : "" second attempt.

@glisignoli glisignoli force-pushed the 209_deb_repository_default_remote branch from 6c5a5bf to 1b7278c Compare July 22, 2025 21:54
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks really good now. I have one last very little request (to help future maintenance).
Let's see what the automated tests say. ;)

@glisignoli glisignoli force-pushed the 209_deb_repository_default_remote branch from 1b7278c to 87fc970 Compare July 23, 2025 19:48
@mdellweg mdellweg enabled auto-merge July 23, 2025 22:49
@mdellweg mdellweg merged commit 7d32c62 into pulp:develop Jul 23, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deb_repository missing optional remote option

2 participants