Use a CS10-based CI image#7771
Draft
dralley wants to merge 2 commits into
Draft
Conversation
dralley
force-pushed
the
cs10-ci
branch
2 times, most recently
from
d3d02a7 to
31c0673
Compare
gerrod3
reviewed
Jun 4, 2026
| "pulp-glue>=0.30.0,<0.40", | ||
| "pygtrie>=2.5,<=2.5.0", | ||
| "psycopg[binary]>=3.1.8,<3.4", # SemVer, not explicitely stated, but mentioned on multiple changes. | ||
| "psycopg[binary]>=3.3.4,<3.4", # SemVer, not explicitely stated, but mentioned on multiple changes. |
Contributor
There was a problem hiding this comment.
Does cs10 require a bump in this requirement?
Contributor
Author
There was a problem hiding this comment.
The lowerbounds PR runner was failing because psycopg[binary] didn't have pre-built wheels for Python 3.12
With that said the lowerbounds probably does not need to be bumped this much and we can relax it if we need to, I just wanted to move past that issue.
Contributor
Author
There was a problem hiding this comment.
OTOH, pip installs are sticky so users will never get an upgrade unless we bump the minimum bound. Might be worth just doing it.
Member
There was a problem hiding this comment.
If we cannot test it we should most definitely bump it.
dralley
force-pushed
the
cs10-ci
branch
2 times, most recently
from
860e44f to
fe02e8c
Compare
dralley
force-pushed
the
cs10-ci
branch
5 times, most recently
from
0473788 to
02af214
Compare
The test_async_pull_through_add test needed transaction=True because sync_to_async runs on a thread pool worker with a separate DB connection that can't see the main thread's uncommitted savepoint data. Using TransactionTestCase exposed two additional issues: - The base Repository has CONTENT_TYPES = [], so the task failed with "unsupported content types". Patch CONTENT_TYPES on the class so the re-fetched repo instance in the task also sees it. - TransactionTestCase teardown calls flush which emits post_migrate signals, but Django's emit_post_migrate_signal doesn't pass the `apps` kwarg. Made all four post_migrate handlers accept apps=None with a fallback to django.apps.apps. - After flush, the global default_domain cache is stale (old PK no longer in DB). Clear it in _ensure_default_domain so the domain is re-created, preventing FK violations in subsequent handlers. Also mock redis_tasks.async_are_resources_available for runners that use WORKER_TYPE=redis, where the dispatch path bypasses the postgres advisory lock code entirely and tries to connect to Redis. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.