Allow null values for Package.evr field #4233
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The evr (Epoch-Version-Release) field in the Package model currently does not allow null values, which causes database errors when syncing certain RPM packages that may have missing or incomplete EVR data. This change adds null=True, blank=True, and default=None to the RpmVersionField to handle cases where packages don't have proper EVR metadata, preventing sync failures. Fixes database constraint violations during package synchronization.
Contributor
|
I would say this is probably not the correct fix. @jamesw-meta Could you open up an issue with more specifics about the problem you're having and we can discuss the best solution? |
Contributor
|
@jamesw-meta And is this the issue you're seeing? #4227 |
Contributor
|
@jamesw-meta ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
While deploying Pulp in our environment, we encountered sync failures for upstream repositories containing packages with missing or incomplete EVR metadata. This patch resolves the issue and allows those repositories to sync successfully.
Solution
Modified the
evrfield in the Package model to accept null values by addingnull=True,blank=True, anddefault=NonetoRpmVersionField. The existing database trigger continues to automatically populate the EVR field when complete metadata is available.Changes
pulp_rpm/app/models/package.pyline 143CHANGES/.bugfixchangelog entrypulp_rpm/tests/unit/test_package_null_evr.pyunit testsTest Plan