Adds implementation fetch #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
Interesting, I've never encountered this issue. Totally up to you if you want to contribute or manage it yourself — I appreciate the PR nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great service so far! I really like it. However, I noticed that when I tried to fetch the ABI for contracts that are proxies, it does not return the ABI of the implementation. The ABI of the implementation is useful since it describes the proxy as well. I've added a bit of code that will fetch the ABI of the implementation (if it exists) and return it.
This PR is a spike -- more to start conversation around this feature set and show a minimal POC. If this is something you are interested in I think we will need to update the viem publicClients so it supports all of the networks you are currently supporting. It shouldn't be too bad, but I didn't want to do it unless you think this is something that you'd want to add into your service. Happy to take it on if this seems interesting to you though!
Opening this PR to get the convo going, if it's not something you are interested in, no problem, I'll just host this myself.
Example proxy contract if you want to test (on mainnet):
0x1eD51f1c554D132B5f62bf7b510eA4bD3e7f004E