Skip to content

Ensure close and connection_lost do not race in Win32#101

Merged
puddly merged 8 commits into
devfrom
puddly/windows-clean-close
Jun 9, 2026
Merged

Ensure close and connection_lost do not race in Win32#101
puddly merged 8 commits into
devfrom
puddly/windows-clean-close

Address review feedback

4b21dd2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 9, 2026 in 1s

92.15% (-0.05%) compared to fb3ef82

View this Pull Request on Codecov

92.15% (-0.05%) compared to fb3ef82

Details

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.15%. Comparing base (fb3ef82) to head (4b21dd2).

Files with missing lines Patch % Lines
serialx/platforms/serial_win32.py 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #101      +/-   ##
==========================================
- Coverage   92.20%   92.15%   -0.05%     
==========================================
  Files          22       22              
  Lines        3654     3660       +6     
==========================================
+ Hits         3369     3373       +4     
- Misses        285      287       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.