feat(iframe): add custom stylesheet support#1523
Open
allandelmare wants to merge 2 commits intopuckeditor:mainfrom
Open
feat(iframe): add custom stylesheet support#1523allandelmare wants to merge 2 commits intopuckeditor:mainfrom
allandelmare wants to merge 2 commits intopuckeditor:mainfrom
Conversation
The style loading validation was comparing against elements.length instead of filtered.length. When stylesheets are dynamically added (e.g., Monaco editor CSS), the elements array grows but filtered remains the same, causing the completion check to never trigger. Closes puckeditor#1324
- Add stylesheets array to IframeConfig for injecting custom CSS URLs - Add onStylesLoaded callback to IframeConfig for notification when ready - Create customStylesheets prop on AutoFrame component - Inject custom stylesheets after host styles, track loading via onload/onerror - Add 10s timeout fallback for reliability when stylesheets fail to load - Properly clear timeout when all styles load successfully - Handle edge case where there are no stylesheets to load Closes puckeditor#1515
|
@allandelmare is attempting to deploy a commit to the Puck Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for injecting custom stylesheets into the iframe that participate in the
waitForStylesmechanism.Changes
stylesheetsarray toIframeConfigfor custom CSS URLsonStylesLoadedcallback toIframeConfig<link>elements after host stylesonload/onerrorhandlersUsage
Test plan
<head>onStylesLoadedcallback fires after all styles loadstylesheetsnot providedCloses #1515