Fix subscribe event engine mutex deadlock and improve validation.#244
Open
KGronek-Pubnub wants to merge 1 commit intomasterfrom
Open
Fix subscribe event engine mutex deadlock and improve validation.#244KGronek-Pubnub wants to merge 1 commit intomasterfrom
KGronek-Pubnub wants to merge 1 commit intomasterfrom
Conversation
… missing openssl uagent macros.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(subscribe-ee): fix mutex deadlock during unsubscribe operations
Fix mutex deadlock where
ee->mutwwas held while calling helper functions that tried to acquire the same mutex again. Release mutex after array operations but before calling nested functions.fix(logger): improve context pointer validation
Replace
NULL == pbchecks with!pb_valid_ctx_ptr(pb)in logger public API for stronger context pointer validation, consistent with the rest of the codebase.fix(version): add missing pubnub_uagent for OpenSSL platform
Add missing
pubnub_uagent()function implementation for OpenSSL platform as declared inpubnub_version.h. Updatepubnub_uname()format to match Windows and POSIX implementations and addPUBNUB_SDK_VERSION_SUFFIXsupport.