Merged
Conversation
Allows users to customize key bindings for results screen actions (quit, restart, repeat, practice missed/slow) and the new test key (Tab) through a [key_map] section in config.toml. Supports single characters, special keys (Tab, Space, etc.), and Ctrl/Alt modifiers. - Add KeyMap struct with KeyBinding type and serde deserialization - Add key parsing for chars, special keys, and C-/A- modifiers - Add conflict detection with warnings on startup - Update results screen to show configured key labels dynamically - Refactor ThemedWidget to receive &Config (access to both theme and key_map) - Add 10 new tests for parsing, matching, config, and conflicts Closes #42 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…l errors - Fix Unicode character parsing (use chars().count() instead of len()) - Include hardcoded Esc and Ctrl+C in conflict detection - Replace config panic with graceful fallback to defaults - Add 4 new tests: Unicode parsing, Esc/Ctrl+C conflicts, empty string Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[key_map]section to config.toml for customizing key bindings"q"), special keys ("Tab","Space"), and modifiers ("C-r"for Ctrl+R,"A-q"for Alt+Q)Design Decisions
"q"binding)&Configinstead of&Themefor clean key_map access in renderingTest plan
Closes #42
🤖 Generated with Claude Code