Skip to content

Reorder the homepage character bar #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptrlrd merged 1 commit into from
Jul 10, 2026
Merged

Reorder the homepage character bar #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/app/HomeClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
const CHARACTERS = [
{ id: "ironclad", cssColor: "var(--color-ironclad)" },
{ id: "silent", cssColor: "var(--color-silent)" },
{ id: "defect", cssColor: "var(--color-defect)" },
{ id: "necrobinder", cssColor: "var(--color-necrobinder)" },
{ id: "regent", cssColor: "var(--color-regent)" },
{ id: "necrobinder", cssColor: "var(--color-necrobinder)" },
{ id: "defect", cssColor: "var(--color-defect)" },
];

const FALLBACK_DESCS: Record<string, string> = {
Expand Down Expand Up @@ -72,7 +72,7 @@
.then(setStats);
cachedFetch<Translations>(`${API}/api/translations?lang=${lang}`)
.then(setTranslations);
}, [lang]);

Check warning on line 75 in frontend/app/HomeClient.tsx

View workflow job for this annotation

GitHub Actions / Frontend lint & type-check 

React Hook useEffect has a missing dependency: 'initialStats'. Either include it or remove the dependency array

// Section name: use game translations if actually translated, otherwise our UI translations
const SECTION_LABEL_MAP: Record<string, string> = {
Expand Down Expand Up @@ -213,7 +213,7 @@
style={{ background: `linear-gradient(to top, ${char.cssColor}66, transparent)` }}
/>
<div className="relative aspect-square flex items-end justify-center overflow-hidden">
<img

Check warning on line 216 in frontend/app/HomeClient.tsx

View workflow job for this annotation

GitHub Actions / Frontend lint & type-check 

Using `<img>` could result in slower LCP and higher bandwidth. Consider using `<Image />` from `next/image` or a custom image loader to automatically optimize images. This may incur additional usage or cost from your provider. See: https://nextjs.org/docs/messages/no-img-element
src={imageUrl(`/static/images/characters/combat_${char.id}.webp`)}
alt={`${charName} - Slay the Spire 2 Character`}
className="w-full h-full object-contain p-1 sm:p-2 group-hover:scale-105 transition-transform duration-300"
Expand Down Expand Up @@ -426,7 +426,7 @@
>
<div className="absolute inset-0 opacity-0 group-hover:opacity-100 transition-opacity bg-gradient-to-r from-[var(--accent-gold)]/15 via-transparent to-transparent" />
<div className="relative bg-black sm:w-48 flex-shrink-0">
<img

Check warning on line 429 in frontend/app/HomeClient.tsx

View workflow job for this annotation

GitHub Actions / Frontend lint & type-check 

Using `<img>` could result in slower LCP and higher bandwidth. Consider using `<Image />` from `next/image` or a custom image loader to automatically optimize images. This may incur additional usage or cost from your provider. See: https://nextjs.org/docs/messages/no-img-element
src="/overwolf-logo.png"
alt="Overwolf"
className="w-full h-full object-cover"
Expand Down
Loading