Fix CI failures from grove-to-project rename#112
Closed
scion-gteam[bot] wants to merge 1 commit into
Closed
Conversation
- Remove unused _linkedTelegramId state property in profile-telegram.ts that was causing TypeScript TS6133 error - Update completion_helper.go to read the renamed "project" flag instead of deprecated "grove" - Update completion_helper_test.go to use "project" flag and check error return from FlagSet.Set
Owner
|
This pull request has been recreated on the target repository as GoogleCloudPlatform#282. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_linkedTelegramIdstate property inprofile-telegram.tsthat was causing TypeScript TS6133 error ("declared but never read")completion_helper.goto read the renamed--projectflag instead of deprecated--grove, fixing a mismatch left from Rename internal grove usages to project GoogleCloudPlatform/scion#281completion_helper_test.goto use the--projectflag and check the error return fromFlagSet.Set, fixing the golangci-lint errcheck violationTest plan
go test ./cmd/ -run TestGetAgentNamespassesnpx tsc --noEmitpasses in web/completion_helper_test.go:77