Rename internal grove usages to project#111
Closed
scion-gteam[bot] wants to merge 13 commits into
Closed
Conversation
Update user-facing messages and code comments to use "project" instead of "grove" terminology.
…edule Update user-facing help text and code comments to use "project" instead of "grove" terminology.
Update user-facing messages and code comments to use "project" instead of "grove" terminology.
…oreground Update code comments, log messages, and user-facing warning text to use "project" instead of "grove" terminology.
…g_install Update code comments, help text, and user-facing messages to use "project" instead of "grove" terminology.
…atcher Update code comments and log messages to use "project" instead of "grove" terminology.
…til, runtimebroker types Update internal comments, parameter names, and doc strings in pkg/ files that are not backward-compat surfaces. JSON/YAML struct tags, env var strings, NATS topic strings, storage paths, query params, container labels, and legacy-compat Marshal/Unmarshal comments are intentionally left unchanged.
…dd --project flag to fs-watcher - Rename embedded config file and update its internal comments - Update koanf.go reference to the new filename - Add --project flag to fs-watcher-tool (keep --grove as deprecated alias) - Update fs-watcher error message to reference --project
Update test files to match the grove→project rename in production code:
- Rename groveDir→projectDir local variables across cmd/ tests
- Update comments from "grove" to "project" terminology
- Fix list_test.go assertions to match updated production output
("No active agents found in the current project/across any projects")
- Update server_dispatcher_test.go test data (grove→project variable
and store objects)
- Update comment-only references in pkg/ test files
Preserved all backward-compat test surfaces:
- --grove flag references (deprecated flag testing)
- grove_id config keys, SCION_GROVE_ID env vars
- /api/v1/groves/ API endpoints
- scion.grove.* NATS topics
- Arbitrary test ID values like "grove-del-123"
Replace individual agent project logs with a single consolidated entry summarizing the full scope of changes and what was intentionally preserved.
Owner
|
This pull request has been recreated on the target repository as GoogleCloudPlatform#281. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames internal-only "grove" usages to "project" across the codebase — variable names, function parameters, comments, log messages, user-facing strings (help text, warnings, prompts), an embedded config file, and the fs-watcher-tool CLI flag.
Closes #101
What changed (46 files, ~340 lines)
cmd/): Updated help strings inmessage,stop,suspend,list,server,config,template_importand comments across 16 cmd/ filesserver_foreground.go, error strings inlist.go,delete.go,harness_config_install.gogroveDir→projectDir,grovePath→projectPathincompletion_helper.go,agentcache/cache.go, and othersdefault_grove_settings.yaml→default_project_settings.yaml(file rename + internal comment updates)--projectflag, kept--groveas deprecated aliaspkg/harness/,pkg/secret/,pkg/util/git.go,pkg/runtimebroker/types.go,pkg/projectsync/What was NOT changed (backward-compat surfaces)
All wire-format and backward-compatibility surfaces are preserved:
json:"groveId", etc.)scion.grove,scion.grove_id,scion.grove_path)SCION_GROVE_ID,SCION_GROVE,SCION_GROVE_PATH)scion.grove.<id>.*)--groveCLI flag definitions/api/v1/groves/*API endpointsgrove_id,hub.groveId)These are tracked in #101 for a future coordinated breaking-change release.
Test plan
go build ./...passesmake lintpassesmake test-fast— all failures are pre-existing (Docker unavailable in test env, hub env state)make fmt-check— pre-existing format issues only (unrelated files)