Converge 'hub-native' naming to 'hub-managed'#110
Closed
scion-gteam[bot] wants to merge 5 commits into
Closed
Conversation
Converge naming for hub-created projects from the inconsistent "hub-native" to the canonical "hub-managed" terminology. Changes: - Rename constant ProjectTypeHubNative → ProjectTypeHubManaged (value "hub-native" → "hub-managed") - Rename functions: hubNativeProjectPath → hubManagedProjectPath, initHubNativeProject → initHubManagedProject, findAgentInHubNativeProjects → findAgentInHubManagedProjects, syncHubNativeWorkspaceBack → syncHubManagedWorkspaceBack - Rename test helpers and test function names accordingly - Update all comments from "hub-native"/"Hub-native" to "hub-managed"/"Hub-managed" Part of #96
- Change ProjectType from 'hub-native' to 'hub-managed' in types.ts - Rename "Hub Workspace" label to "Hub-managed Workspace" in project creation form - Update git-remote-display fallback text to "Hub-managed workspace" Part of #96
Update all occurrences of "hub-native", "Hub-native", "Hub-Native", "Hub Workspace" to their "hub-managed"/"Hub-managed" equivalents across documentation, design docs, changelogs, and glossaries. Part of #96
Update test fixture names from "Hub Native" to "Hub Managed" so that auto-derived slugs match expected values in assertions. Part of #96
Owner
|
This pull request has been recreated on the target repository as GoogleCloudPlatform#280. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #96
Converges the inconsistent "hub-native" / "Hub Workspace" naming to the canonical "hub-managed" terminology across the entire codebase.
ProjectTypeHubNative→ProjectTypeHubManaged(value"hub-native"→"hub-managed"),hubNativeProjectPath→hubManagedProjectPath,initHubNativeProject→initHubManagedProject,findAgentInHubNativeProjects→findAgentInHubManagedProjects,syncHubNativeWorkspaceBack→syncHubManagedWorkspaceBackProjectTypechanged from'hub-native'to'hub-managed'; label changed from "Hub Workspace" to "Hub-managed Workspace" in create dialog and git-remote displayWire-value note
The
projectTypeAPI response field changes from"hub-native"to"hub-managed". This value is computed (not stored in DB) bypopulateProjectType(), so no data migration is needed. Per CLAUDE.md, the project is in alpha and does not require graceful deprecation for behavioral changes.Test plan
go vet ./...passesgo build ./...compiles cleanlypkg/store,pkg/hub,pkg/runtimebroker,pkg/storage)hub-native/HubNative/hubNativereferences in.goor.tssource files (verified via grep)