Migrate Claude harness from builtin to container-script provisioning#109
Closed
scion-gteam[bot] wants to merge 1 commit into
Closed
Migrate Claude harness from builtin to container-script provisioning#109scion-gteam[bot] wants to merge 1 commit into
scion-gteam[bot] wants to merge 1 commit into
Conversation
Move the Claude harness from the compiled-in builtin provisioner to the extensible container-script model, matching what OpenCode and Codex already use. This is the first concrete step in retiring the builtin provisioner path (refs #100). The container-side provision.py handles: - Auth resolution with Claude's 4-way precedence (API key → OAuth token → auth-file → Vertex AI) - API key pre-approval fingerprint in .claude.json - Project workspace path setup in .claude.json - MCP server translation via scion_harness helper - Auth env var overlay output for the runtime The compiled ClaudeCode harness is kept intact as a fallback for existing installations that haven't upgraded their harness-config. Includes parity tests and Python integration tests that verify the script produces identical outputs to the compiled harness.
Owner
|
This pull request has been recreated on the target repository as GoogleCloudPlatform#279. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provision.pyfor Claude that handles auth resolution, API key pre-approval, project path setup, and MCP server translationRefs #100
What changed
pkg/harness/claude/embeds/config.yaml: Changedprovisioner.typefrombuiltintocontainer-scriptand added MCP capabilities block.pkg/harness/claude/embeds/provision.py(new): Container-side provisioner script handling:.claude.json(mirrorsClaudeCode.ApplyAuthSettings).claude.json(mirrorsClaudeCode.provisionClaudeJSON)scion_harness.apply_mcp_servers_simple()pkg/harness/claude_parity_test.go(new): 11 tests covering:TestClaudeEmbedsSeedRootSupportFiles)TestClaudeActivateScriptIsIdempotent)TestClaudeContainerScriptHarnessParity)What remains (tracked in #100)
provision.py(follow-up PR)newBuiltin()fromresolve.goand the compiled provisioning methodsThe compiled
ClaudeCodeharness is intentionally kept as a fallback for existing installations that haven't upgraded their harness-config.Test plan
go vet ./pkg/harness/...cleango build ./...succeeds