Rename messaging "set" concept to "message group"#108
Closed
scion-gteam[bot] wants to merge 4 commits into
Closed
Conversation
Rename SetRecipient→GroupRecipient, IsSetRecipient→IsGroupRecipient, ParseSetRecipient→ParseGroupRecipient, FormatSetRecipients→FormatGroupRecipients, sendSetMessageViaHub→sendGroupMessageViaHub, PublishToSet→PublishToGroup, handleSetMessage→handleGroupMessage, and related response types across cmd/message.go, pkg/messages, pkg/hub, and extras/scion-telegram. The user-facing wire-format syntax (set[...]) is unchanged for backward compatibility. Deprecated type aliases and wrapper functions are provided for SetRecipient, IsSetRecipient, ParseSetRecipient, FormatSetRecipients, and MaxSetRecipients. Resolves #94
Owner
|
This pull request has been recreated on the target repository as GoogleCloudPlatform#278. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set[...]CLI wire-format syntax via backward-compatible aliasesResolves #94
Changes
SetRecipientGroupRecipient(type alias kept)IsSetRecipient()IsGroupRecipient()(deprecated wrapper kept)ParseSetRecipient()ParseGroupRecipient()(deprecated wrapper kept)FormatSetRecipients()FormatGroupRecipients()(deprecated wrapper kept)sendSetMessageViaHub()sendGroupMessageViaHub()handleSetMessage()handleGroupMessage()PublishToSet()PublishToGroup()set.go/set_test.gomessage_group.go/message_group_test.goWire-format constants (
SetPrefix,SetSuffix,TypeGroupSet) are unchanged.Test plan
pkg/messagestests pass (renamed tests + deprecated alias tests)cmdmessage-related tests pass (TestSetRecipientFlagValidation,TestSendGroupMessageViaHub,TestSendGroupMessageViaHub_RequiresHub)TestMessageBrokerProxy_PublishToGrouppasses inpkg/hubgo vetclean on all affected packagesgo build ./...succeedsgofmtissues in touched files fixed