Make templates fully harness-agnostic: model aliases, deprecate image/auth#106
Closed
scion-gteam[bot] wants to merge 4 commits into
Closed
Make templates fully harness-agnostic: model aliases, deprecate image/auth#106scion-gteam[bot] wants to merge 4 commits into
scion-gteam[bot] wants to merge 4 commits into
Conversation
Templates should be strictly harness-agnostic. This change: - Adds ModelAliases (small/medium/large) to HarnessConfigEntry so each harness-config can map abstract sizes to concrete model names - Adds ResolveModelAlias() to resolve aliases at provision time - Adds WarnDeprecatedTemplateFields() to warn when templates use image, auth_selectedType, or concrete model names - Marks image and auth_selectedType as deprecated in agent-v1 schema - Updates model field description to recommend size aliases - Adds model_aliases to settings-v1 schema - Seeds default model_aliases in all harness embeds (claude, gemini, opencode, codex) - Wires alias resolution and deprecation warnings into ProvisionAgent Concrete model names in templates still work (pass-through) for backward compatibility. Refs #98, relates to #42.
… boundary - Add note that image/model/auth belong in harness-config, not templates - Add "Model Size Aliases" section explaining small/medium/large aliases - Update harness-config customization example to show alias mapping Refs #98
Tests cover: - ResolveModelAlias: alias resolution, concrete passthrough, nil/empty handling, unmapped aliases - WarnDeprecatedTemplateFields: clean templates, size alias models, deprecated image/auth/concrete-model fields - KnownModelAliases: validates the canonical alias set Refs #98
Owner
|
This pull request has been recreated on the target repository as GoogleCloudPlatform#276. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Templates should be strictly harness-agnostic — they define the agent's role, not its execution mechanics. This PR:
small,medium,large) to harness-configs, resolved to concrete model names at provision time. Templates can usemodel: largeinstead ofmodel: opus, making them portable across Claude, Gemini, and other backends.image,auth_selectedType, concretemodelnames) inscion-agent.yamlwith warnings, guiding users to move these to harness-configconfig.yaml.templates.md) to clarify the template/harness-config boundary and document model aliases.Closes #98. Implements the model alias portion of #42.
Changes
pkg/config/settings_v1.go: AddModelAliasestoHarnessConfigEntrypkg/config/templates.go: AddResolveModelAlias(),WarnDeprecatedTemplateFields(),KnownModelAliasespkg/agent/provision.go: Wire alias resolution and deprecation warnings into provisioning flowpkg/config/schemas/agent-v1.schema.json: Markimage,auth_selectedTypeas deprecated; updatemodeldescriptionpkg/config/schemas/settings-v1.schema.json: Addmodel_aliasesproperty to harness config schemapkg/hubclient/types.go,pkg/store/models.go: AddModelAliasestoHarnessConfigDatapkg/harness/*/embeds/config.yaml: Seed default model aliases for all harnessesdocs-site/src/content/docs/advanced-local/templates.md: Document model aliases, clarify harness-agnostic boundaryBackward Compatibility
imageandauth_selectedTypestill work as override valuesTest plan
ResolveModelAlias()— alias resolution, concrete passthrough, nil/empty handlingWarnDeprecatedTemplateFields()— all deprecated field combinationsKnownModelAliases— canonical alias set validationgo vetandgo buildpass