[BOX32] Fix copy-paste bug in SDL_ShowMessageBox#3619
Merged
ptitSeb merged 1 commit intoptitSeb:mainfrom Mar 6, 2026
Merged
Conversation
In my32_2_SDL_ShowMessageBox, the loop converting 32-bit SDL_MessageBoxButtonData to 64-bit incorrectly read src[i].buttonid for all three fields instead of src[i].flags and src[i].text. This caused the button text pointer to be set to a small integer, resulting in a SIGSEGV when native SDL tried to read the text string.
Contributor
Author
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
my32_2_SDL_ShowMessageBox, the loop converting 32-bitSDL_MessageBoxButtonDatato 64-bit incorrectly readsrc[i].buttonidfor all three fields instead ofsrc[i].flagsandsrc[i].text.