[RV64_DYNAREC] SET_ELEMENT_WIDTH always call vector_vsetvli#3615
[RV64_DYNAREC] SET_ELEMENT_WIDTH always call vector_vsetvli#3615zqb-all wants to merge 1 commit intoptitSeb:mainfrom
Conversation
|
I guess your are vibe coding here. For the 1. you added code just after |
ptitSeb
left a comment
There was a problem hiding this comment.
Use fpu_pushcache(...) (and don't forget fpu_popcache(...) instead of forgetting all SSE regs.
Yes, claude helped generate some code.
Oh, my mistake, I had seen that before, but later when I realized I needed to Forget all registers, I forgot about it. I'll go and make the changes. |
|
The TL;DR: you are sure your issue is the clober of the XMM0..7 regs? and not just the vector setup instead? |
|
You're right, sorry for the confusion — I wasn't familiar enough with the x86 ABI and didn't verify carefully before commit. Thanks for the clarification, I now have a much better understanding of the code. I'll update the patch soon after some wemeet test. |
|
I previously thought I had found the cause, but after further testing, simply modifying the SET_ELEMENT_WIDTH can also avoid the wemeet crash. Now I'm not entirely sure if this is the final solution, so I've set it as WIP for now. |
SET_ELEMENT_WIDTH always call vector_vsetvli