amend z-index to bring 2D UI to foreground#536
Open
Conversation
Contributor
ktheo-ptc
commented
Oct 17, 2023
ktheo-ptc
commented
- adjusts z-index to bring 2D UI to foreground
…s from recentlyUsedBar on desktop
Tries to more elegantly handle minimum timeline width, fix initial load of hpa after recording finished (unsuccessfully), and simplifies and optimizes bestClonesByTimestamp logic
setDisplayRegion can be called before the message setting the active analytics frame to the correct one so the extra setDisplayRegion would go to the 'none' analytics, causing everything to be loaded twice over.
Allows remote pose tracking to be a little sloppier while remaining within the wider 500 ms tolerance window the timeline establishes.
…d touch intersection point
Spaghetti now fades out if it is not the one the user is interacting …
* Changed reception of poses stream from Swift to reflect new data structure. * Added passing of extra frame data (camera calibration) together with human pose.
Avatar lines
Adds -webkit-user-drag:none to all elements; disables hover on mobile ru-icons
…lytics tool is opened
Load history fix
This reverts commit ccc3a33.
Display region fix
…or or ios patches taken on remote-operator show up in the right spot on remop or in AR. mobile ones do not.
… or on remote operator, and appear in the right spot; only missing feature is the snapshots dont immediately appear in AR if taken on the mobile device, only if taken on remop
…quested the capture
…r. Improves shader for spatial snapshots to fade to flat shading when viewing angle and position approach the angle/position that the photo was taken from
…tial patches working cleanly
… longer initializing before
Fixes live analytics menu from being offscreen due to session menu no…
…that multiple minimized (but open) tools dont all add the subtools within them
Take spatial snapshots on iOS device; refactor SpatialSnapshotCoordinator out of CameraVisCoordinator; implement capture APIs
dangond-ptc
approved these changes
Oct 18, 2023
hobinjk-ptc
suggested changes
Oct 18, 2023
Contributor
hobinjk-ptc
left a comment
hobinjk-ptc
left a comment
There was a problem hiding this comment.
Minor issue on Safari: If the scene contains a minimized drawing tool something goes wrong and right-clicking brings up the context menu. Not actually sure what's happening here since adding a contextmenu listener with event.preventDefault isn't making it go away
Contributor
|
I think the z-index adjustment should be fine. I remember running into that context menu issue before and I thought I found a reason for it – I'll look into this now. |
hobinjk-ptc
reviewed
Oct 18, 2023
| tempThisObject.fullscreenZPosition = msgContent.fullscreenZPosition; | ||
| } | ||
|
|
||
Contributor
There was a problem hiding this comment.
nit: trailing whitespace
hobinjk-ptc
approved these changes
Oct 18, 2023
Contributor
hobinjk-ptc
left a comment
hobinjk-ptc
left a comment
There was a problem hiding this comment.
LGTM with one lint and one comment inline
| globalStates.platform = false; | ||
| } | ||
|
|
||
| if (realityEditor.device.environment.isSafari()) { |
Contributor
There was a problem hiding this comment.
This should have a comment on why ("iframes in safari intercept pointer-events if not given a negative z-index") it's done
dangond-ptc
approved these changes
Oct 18, 2023
hobinjk-ptc
force-pushed
the
amend-z-index
branch
from
944d083 to
99778c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.