Conversation
…ectory when needed
…overs all the public methods for RemediatedFinalSubmissionFile
…ds function to delete RemediatedFinalSubmissionFile when object is destroyed
jlandiseigsti
approved these changes
Jan 23, 2026
Contributor
jlandiseigsti
left a comment
jlandiseigsti
left a comment
There was a problem hiding this comment.
Appreciate the clarifying comments, and the extra effort to write submission_release_service specs to make up for a previous lack. Looks great!
| end | ||
|
|
||
| def move_a_file(fid, original_file_location) | ||
| # file_class injection options: [FinalSubmissionFile, RemediatedFinalSubmissionFile] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #968
Makes
RemediatedFinalSubmissionFilebehave similarly toFinalSubmissionFilewhen saving, deleting, publishing and unpublishing. A major part of this is moving the file around depending on the published status and access level of the associated submission.I think #960 will need merged to main and then merged here to get the last test to pass.Edit: I fixed the test so this is good to goThis depends on psu-libraries/etda_utilities#41 in etda_utilities, which was merged, published, and updated in this PR.
There were no unit tests for a lot of the public interface for
SubmissionReleaseService. I had to add them to test my changes.