-
Notifications
You must be signed in to change notification settings - Fork 170
refactor: Update SceInit stub with the discovered names for functions
#351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if a function pointer is expected, shouldn't we use a proper function prototype for the callback?
either using a typedef or fully inline as in e.g. qsort:
void qsort(void *base, size_t nel, size_t width, int (*compar)(const void *, const void *));There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless this works like e.g.
scnum = sceKernelQuerySystemCall(sceKernelQuerySystemCall);in which case the function documentation is kinda lacking/misleading. if so it would also be interesting to know what the result is good for and how it can be used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is, there is no way do descrive a system call function "shape" (case in point:
sceIoReadandsceKernelRegisterExitCallbackare both syscalls, but they don't share the same number of arguments, these arguments don't have the same types, in this case the return type is the same, but could be different)Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be used to know if a given function is exported as syscall, it also can be used to create a system call instruction to insert in a module to patch it. You can give a look into the ARK or Adrenaline implementation of
sctrlHookImportByNIDto see it being used to both check the function is exported as syscall and to create and patch a syscall instruction