fix: re-render tutorial when language is changed mid-session#142
Merged
pshenok merged 2 commits intopshenok:mainfrom Mar 9, 2026
Merged
fix: re-render tutorial when language is changed mid-session#142pshenok merged 2 commits intopshenok:mainfrom
pshenok merged 2 commits intopshenok:mainfrom
Conversation
Convert TUTORIAL_STEPS from a static const array to getTutorialSteps() function so translations are evaluated lazily at render time instead of at file load. Also replace hardcoded 'Start Playing!' and 'Next' button labels with i18n.t() calls. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add localeChanged event listener to Tutorial so that showStep() is called when the language is switched mid-tutorial. Previously, applyTranslations() only updated data-i18n elements and the tutorial popup was not re-rendered. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 tasks
pshenok
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TUTORIAL_STEPSfrom a static array to agetTutorialSteps()function so tutorial text is evaluated lazily at render timelocaleChangedevent listener to theTutorialclass soshowStep()is called whenever the language changes mid-tutorialPreviously, all tutorial text was evaluated once at script load time (before the user selects a language), meaning switching languages had no effect on the tutorial popup. This fix ensures the tutorial always reflects the currently selected language.
This bug affects all language options, not just any single locale.
Test plan