fix: cache routing, clear failures button, separate music/SFX controls#128
Closed
TheBestFisch wants to merge 1 commit intopshenok:mainfrom
Closed
fix: cache routing, clear failures button, separate music/SFX controls#128TheBestFisch wants to merge 1 commit intopshenok:mainfrom
TheBestFisch wants to merge 1 commit intopshenok:mainfrom
Conversation
…trols - Fix pshenok#88: Cache no longer routes requests it can't forward. Compute checks that cache can reach the request's destination before sending. Also adds s3 fallback for cdn-destined requests throughout the pipeline. - Fix pshenok#115: Add a "Clear" button to the failures panel so players can reset failure counters during gameplay. - Fix pshenok#112: Split the single mute button into separate Music and SFX toggles in both the toolbar and main menu, allowing independent control. All inline `new Audio()` calls replaced with SoundService. - Add i18n keys (clear, music, sfx) to all 5 locale files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
pshenok
approved these changes
Feb 3, 2026
Owner
|
@TheBestFisch resolve conflict please. "Clear" button - already done before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
s3fallback forcdn-destined requests at both the compute and cache forwarding stages.new Audio()calls replaced withSoundServicemethods so they respect the SFX mute state.clear,music,sfx) to all 5 locale files (EN, ZH, PT-BR, DE, NEP).Test plan
🤖 Generated with Claude Code