Skip to content

fix: cache routing, clear failures button, separate music/SFX controls#128

Closed
TheBestFisch wants to merge 1 commit intopshenok:mainfrom
TheBestFisch:hfi/14a9b0d3-129b-4227-b4ee-02b6a773a89f/B
Closed

fix: cache routing, clear failures button, separate music/SFX controls#128
TheBestFisch wants to merge 1 commit intopshenok:mainfrom
TheBestFisch:hfi/14a9b0d3-129b-4227-b4ee-02b6a773a89f/B

Conversation

@TheBestFisch
Copy link
Copy Markdown

@TheBestFisch TheBestFisch commented Feb 2, 2026

Summary

  • Fix Introducing a Cache to only one service prevents routing to other #88: Cache routing bug — compute now verifies the cache can reach the request's final destination before routing through it. Also adds s3 fallback for cdn-destined requests at both the compute and cache forwarding stages.
  • Fix Clear-able failures list #115: Adds a "Clear" button to the failures panel, allowing players to reset failure counters mid-game without restarting.
  • Fix Separate sound effects and music control #112: Splits the single mute toggle into separate Music and SFX buttons (in both the in-game toolbar and the main menu). All inline new Audio() calls replaced with SoundService methods so they respect the SFX mute state.
  • Adds i18n keys (clear, music, sfx) to all 5 locale files (EN, ZH, PT-BR, DE, NEP).

Test plan

  • Start a Survival game, place Compute → Cache → DB (no S3 connected to cache). Verify STATIC/UPLOAD requests are routed directly to S3 instead of through cache.
  • Place Compute → Cache → DB → S3. Verify READ/SEARCH requests go through cache to DB, and STATIC requests go through cache to S3.
  • Play until failures appear, click the "Clear" button — verify counters reset to 0 and panel hides.
  • Toggle Music off — verify background music stops but SFX (place, connect, success sounds) still play.
  • Toggle SFX off — verify procedural tones and click sounds stop but music continues.
  • Toggle both off and on — verify correct icon states on both toolbar and menu buttons.
  • Switch language and verify "Clear", "Music", "SFX" labels translate correctly.

🤖 Generated with Claude Code

…trols

- Fix pshenok#88: Cache no longer routes requests it can't forward. Compute
  checks that cache can reach the request's destination before sending.
  Also adds s3 fallback for cdn-destined requests throughout the pipeline.
- Fix pshenok#115: Add a "Clear" button to the failures panel so players can
  reset failure counters during gameplay.
- Fix pshenok#112: Split the single mute button into separate Music and SFX
  toggles in both the toolbar and main menu, allowing independent
  control. All inline `new Audio()` calls replaced with SoundService.
- Add i18n keys (clear, music, sfx) to all 5 locale files.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@pshenok pshenok self-requested a review February 3, 2026 04:19
@pshenok
Copy link
Copy Markdown
Owner

pshenok commented Feb 3, 2026

@TheBestFisch resolve conflict please. "Clear" button - already done before.

@pshenok pshenok self-requested a review February 3, 2026 04:24
@pshenok pshenok closed this Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear-able failures list Separate sound effects and music control Introducing a Cache to only one service prevents routing to other

3 participants