fix: use urlsplit instead of urlparse for digest auth URI #7197
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
urifield in HTTP Digest Authentication being incorrectly truncated when the URL path contains semicolonsurlparsewithurlsplitinbuild_digest_header()sinceurlparsetreats semicolons as parameter separators (stripping everything after the first;from the path), whileurlsplitcorrectly preserves themFixes #6990
Explanation
Python's
urlparsesplits the path on;and moves the content after it to aparamsattribute:urlsplitdoes not have this behavior and keeps the full path intact:Since only
pathandqueryare used from the parsed result (notparams),urlsplitis a safe drop-in replacement that correctly preserves the full request URI as required by RFC 7616.Test plan