Fix: Correct Content-Length for StringIO with multi-byte characters#7151
Open
hcthakur2004 wants to merge 1 commit intopsf:mainfrom
Open
Fix: Correct Content-Length for StringIO with multi-byte characters#7151hcthakur2004 wants to merge 1 commit intopsf:mainfrom
hcthakur2004 wants to merge 1 commit intopsf:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression where
Content-Lengthis incorrectly calculated forio.StringIOobjects containing multi-byte characters (like emojis).The Issue
When
io.StringIOis passed asdata, super_len uses character count via len or tell() instead of the UTF-8 encoded byte length. This mismatch causes server errors when the encoded body is larger than the reported length.The Fix
Updated super_len in utils.py to encode
StringIOcontent to UTF-8 before calculating length, matching the behavior for standard strings andurllib3expectations.