fix: use context manager for ZipFile in extract_zipped_paths#7127
Open
shindonghwi wants to merge 2 commits intopsf:mainfrom
Open
fix: use context manager for ZipFile in extract_zipped_paths#7127shindonghwi wants to merge 2 commits intopsf:mainfrom
shindonghwi wants to merge 2 commits intopsf:mainfrom
Conversation
Fix resource leak in extract_zipped_paths() where the ZipFile object was never properly closed. The function opened a ZipFile but returned early in multiple code paths without closing it, potentially leaking file descriptors. This change wraps the ZipFile usage in a context manager to ensure proper cleanup regardless of which code path is taken.
shindonghwi
force-pushed
the
fix/zipfile-resource-leak
branch
from
95c7552 to
52777ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found that
extract_zipped_paths()opens a ZipFile but never closes it.When member is not found and returns early, the ZipFile remains open. Fixed by wrapping with context manager.
Added a test to verify close() is called.