Pfs2tar improvements#51
Merged
uyjulian merged 16 commits intops2homebrew:masterfrom Jul 2, 2025
Merged
Conversation
…le partition copying into tar
Member
|
I think it would be better to have it an option to explicitly specify the output tar name, and when not present, use the automatically generated tar name |
1af11ae to
deba674
Compare
…e files on the HDD, --overwrite needs to be specified
0f6ebba to
653eed5
Compare
Member
Author
|
@uyjulian returned tar filename handle and added option to restore tar archives back to the HDD. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the pfs2tar tool with bidirectional tar support (extract and restore), timezone- and format-aware timestamp/mode conversions, and improved CLI and build integration.
- Added
--extract/--restoremodes with partition and overwrite options - Implemented POSIX-to-iomanX time/mode converters and parent-directory creation
- Updated Meson configs and CI to always build and upload the new
pfs2tarexecutable
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/pfs2tar.c | Added convert functions, restore logic, overwrite flag, and CLI |
| meson_options.txt | Changed enable_pfs2tar default to true |
| meson.build | Refactored pfs2tar executable definition and platform flags |
| .github/workflows/ci.yml | Added -Denable_pfs2tar=true to CI setups and upload artifact |
Comments suppressed due to low confidence (2)
src/pfs2tar.c:179
- This new POSIX-to-iomanX time conversion logic lacks unit tests. Consider adding tests for edge cases (e.g., year boundaries, DST offsets) to validate correctness.
static void convert_posix_time_to_iox_time(time_t posix_time, unsigned char *iomanx_time)
src/pfs2tar.c:534
- [nitpick] The function name
part_taris ambiguous in contrast totar_part; renaming it to something likerestore_tarwould improve clarity.
static int part_tar(const char *arg)
uyjulian
requested changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description