Skip to content

fix(cmc): readOffer must omit streams filter — :_cmc:_internal:offer is not a real parent #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
perki wants to merge 1 commit into from
Closed

fix(cmc): readOffer must omit streams filter — :_cmc:_internal:offer is not a real parent #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions components/pryv-cmc/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,12 +550,20 @@ async function requestScopeUpdate (conn, params) {
async function readOffer (capabilityUrl, opts) {
const pryv = (opts && opts.pryv) || require('pryv');
const cap = new pryv.Connection(capabilityUrl);
// `events.get` takes `streams` (recursive read filter), not `streamIds`
// (which is the events.create write target). Mirror the field used by
// the other events.get callers in this file (listInvites, waitForAccept,
// listAcceptedRelationships).
// The capability access has `read` on a single per-capability stream
// (`:_cmc:_internal:offer:<capId>`) but the accepter doesn't know
// <capId> from the capabilityUrl alone. The parent `:_cmc:_internal:offer`
// is NOT a reserved stream that auto-exists on every user account — only
// the per-capability children do — so a `streams: [':_cmc:_internal:offer']`
// filter resolves to `unknown-referenced-resource`.
//
// Mirror the plugin's own readOfferViaCapability (acceptOrchestration.ts):
// omit the streams filter entirely and rely on the cap access's
// permissions to narrow the response to the single offer event this
// token can read. The `types` filter is defensive in case the offer
// stream ever holds more than one event in future revisions.
const events = await cap.apiOne('events.get', {
streams: [NS_INTERNAL + ':offer'],
types: [ET_REQUEST],
limit: 1
}, 'events');
if (events.length === 0) {
Expand Down
Loading