Bugfix SS pin definitions#2
Open
Hasi123 wants to merge 3 commits into
Open
Conversation
Owner
|
Hi Hasi ! Does you understand how to identify the different board type ? You talk about Pro-Mini only ? |
Author
|
Well you already defined B0 in the code, and for that the port register is PORTB and the ddr is DDRB. I do not understand your question, the SD SS pin is not board dependent, but can be freely chosen depending on where you connect the SS pin of the SD card. |
The bootloader's hex parser did not handle Intel HEX record types other than 0x00 (Data) and 0x01 (EOF). Record type 0x04 (Extended Linear Address) was being treated as data, causing a 2-byte shift in the firmware written to flash. Fix: skip writing to flash for any record type != 0x00. Also disabled LED_START_FLASHES (GNUVario has no status LED) to keep bootloader under 2048 bytes. Bootloader size: 2012 bytes (was 2034)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strangely the old code worked on some boards, but not on others. Found this little bug and thought I would create a pull request.