Open
Conversation
phlax
requested review from
PiotrSikora,
leonm1,
martijneken and
mpwarres
as code owners
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
commented
Jan 21, 2026
| bazel_dep(name = "rules_license", version = "1.0.0") | ||
| bazel_dep(name = "rules_python", version = "1.7.0") | ||
| bazel_dep(name = "rules_rust", version = "0.68.1") | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@leonm1 this currently has no llvm toolchain setup - it should have it added as a dev_dependency
it wont prevent consumers from using it - but you will need the toolchain setup in order to test bzlmod
| use_repo(wamr, "com_github_bytecodealliance_wasm_micro_runtime") | ||
|
|
||
| # V8 runtime and its dependencies | ||
| v8 = use_extension("//bazel:extensions.bzl", "v8") |
Contributor
Author
There was a problem hiding this comment.
ideally we add a v8 (and friends) bzlmod
| ) | ||
|
|
||
| # WasmEdge runtime | ||
| wasmedge = use_extension("//bazel:extensions.bzl", "wasmedge") |
Contributor
Author
There was a problem hiding this comment.
this file was originally bot generated - this is probably correct - but we dont test this in envoy
Contributor
Author
|
format issue looks like another bug in rules_rust - it appears to be detecting whether bzlmod is enabled by the presence of MODULE.bazel - which is very much not correct (or at least it needs to enable bzlmod in that case) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.