Reduce mpol to 6 for solovev_free_bdy to shorten tests#16
Open
jons-pf wants to merge 1 commit intojons-complete-solovev-free-bdy-datafrom
Open
Reduce mpol to 6 for solovev_free_bdy to shorten tests#16jons-pf wants to merge 1 commit intojons-complete-solovev-free-bdy-datafrom
jons-pf wants to merge 1 commit intojons-complete-solovev-free-bdy-datafrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Closed
jons-pf
changed the base branch from
jons-revive-indata-test
to
graphite-base/16
jons-pf
force-pushed
the
graphite-base/16
branch
from
38b40c6 to
cd3b9c3
Compare
jons-pf
force-pushed
the
jons-reduce-mpol-solovev-free-bdy
branch
from
d5ecdd2 to
854ba1d
Compare
jons-pf
changed the base branch from
graphite-base/16
to
jons-complete-solovev-free-bdy-data
jons-pf
force-pushed
the
jons-complete-solovev-free-bdy-data
branch
from
cd3b9c3 to
886ad8a
Compare
jons-pf
force-pushed
the
jons-reduce-mpol-solovev-free-bdy
branch
from
854ba1d to
24d0a3b
Compare
jons-pf
force-pushed
the
jons-reduce-mpol-solovev-free-bdy
branch
from
24d0a3b to
e163fa6
Compare
This was referenced Mar 30, 2026
jurasic-pf
reviewed
Mar 30, 2026
| 0.012651734058868888, | ||
| 0.012640261473126137, | ||
| 0.012570624438821747, | ||
| 0.012283522498829828, |
Contributor
There was a problem hiding this comment.
this seems like a large diff - because of changed resolution?
Contributor
Author
There was a problem hiding this comment.
yep, all test data was re-generated with the more-approriate-for-unit-testing mpol=6 instead of mpol=12 as is currently commited due to me not having made up my mind about this beforehand 🙈
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.