RegularizedIntegrals: fixup for axisymmetric cases#467
Open
jons-pf wants to merge 1 commit intojons-nvper-for-axisymm-nestorfrom
Open
RegularizedIntegrals: fixup for axisymmetric cases#467jons-pf wants to merge 1 commit intojons-nvper-for-axisymm-nestorfrom
jons-pf wants to merge 1 commit intojons-nvper-for-axisymm-nestorfrom
Conversation
This was referenced Mar 30, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
jurasic-pf
reviewed
Mar 30, 2026
|
|
||
| tanu.resize(s_.nThetaEven); | ||
| tanv.resize(s_.nZeta); | ||
| tanv.resize(s_.nZeta * s_.nVacuumPeriods); |
Collaborator
There was a problem hiding this comment.
isnt this nfp for stellarator cases? why do we allocate a bigger array than before?
This was referenced Mar 30, 2026
1162fe3 to
b17dca6
Compare
8d7d926 to
8aa01a1
Compare
b17dca6 to
5191eff
Compare
8aa01a1 to
ac9e4da
Compare
5191eff to
9635447
Compare
ac9e4da to
60e0c17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.