Test normalize currents results in different fields#320
Test normalize currents results in different fields#320jurasic-pf wants to merge 1 commit intojurasic/normalization-was-ignoredfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
tests/test_free_boundary.py
Outdated
|
|
||
| def test_normalize_by_currents(makegrid_params: vmecpp.MakegridParameters): | ||
| makegrid_params.normalize_by_currents = True | ||
| response1 = vmecpp.MagneticFieldResponseTable.from_coils_file( |
There was a problem hiding this comment.
maybe call response1 and response2 something like response_normalized and response_unnormalized?
|
|
||
|
|
||
| def test_normalize_by_currents(makegrid_params: vmecpp.MakegridParameters): | ||
| makegrid_params.normalize_by_currents = True |
There was a problem hiding this comment.
I think normalize_by_currents is misleading here - I chose a bad name - since we actually aim to normalize by the number of windings -> normalize_by_num_windings?
jurasic-pf
force-pushed
the
jurasic/test-normalize-currents
branch
from
11008ab to
f5f2b11
Compare
jurasic-pf
changed the base branch from
graphite-base/320
to
jurasic/normalization-was-ignored
jurasic-pf
force-pushed
the
jurasic/test-normalize-currents
branch
from
f5f2b11 to
b5e398b
Compare
jurasic-pf
force-pushed
the
jurasic/test-normalize-currents
branch
from
b5e398b to
60fdee3
Compare
jurasic-pf
force-pushed
the
jurasic/normalization-was-ignored
branch
from
2fc6321 to
8fbf8de
Compare
2 participants
No description provided.