Conversation
Made `SwiftMessageUtils.md5()` public for checksum computation in custom implementations
…ent access The sort_key column managed by @OrderColumn gets corrupted under race conditions (duplicate/missing values), causing JPA to load incomplete or duplicated status trail entries. Replacing with @orderby("creationDate ASC") delegates ordering to SQL and ensures all records are always loaded regardless of sort_key state. Applied to statusTrail, notes, and revisions fields. Also guards against null creationDate in SwiftMessageStatusInfo 5-arg constructor. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add secondary sort by id to @orderby on statusTrail, notes, and revisions for deterministic ordering when timestamps collide - Initialize SwiftMessageNote.creationDate at field declaration to prevent null ordering - Add null guard to SwiftMessageStatusInfo.setCreationDate() consistent with constructor - Add SwiftMessageStatusInfoTest covering creationDate null-guard behavior Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Code reviewFound 1 issue:
The PR adds null guards to For reference, the guarded version in 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
zubri
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.