Fix post-process dashboard and launch naming issues#102
Merged
Conversation
launch.sh used the raw repository basename for Docker image and container names, which fails when the checkout path contains uppercase characters because Docker repository names must be lowercase. Add a shared project-id helper and use it across launch, dashboard, harvest, progress, costs, and test helpers. The raw repository basename stays in user-facing run context and dashboard titles. Tests cover uppercase and separator-heavy project names in test_launch.sh.
The dashboard only rendered PP after the post-process container existed, so a configured post_process block looked absent during the main agent run. Render a synthetic PP configured row from the swarmfile before the container starts, while preserving the existing Docker-derived row once the container exists. Include the post-process driver in multi-driver column detection. Tests cover pending row defaults, driver and tag inheritance, and post-process driver splits in test_dashboard.sh.
The dashboard showed a PP row once post-processing existed, but there was no shortcut to follow its logs. The previous p/P binding also started post-processing immediately, which made accidental keypresses risky. Split the controls so lowercase p tails an existing PP container and never starts work. Uppercase P starts or replaces post-processing only after confirmation. Tests pin the separate p and P case arms and assert that the lowercase path cannot call launch.sh post-process.
The docs described launch.sh wait as blocking, harvesting, and post-processing without saying that numbered agents must already have been started. That made wait look like an end-to-end launch command. Update command help, README, and USAGE to show the normal start then wait sequence. Also document that harvest.sh only merges local agent work, while post-process runs triage and then harvests. Tests assert the revised launch.sh help text in test_launch.sh.
moodmosaic
force-pushed
the
release/0.20.16
branch
from
c51c6ec to
38643af
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PPcontainer starts.launch.sh waitwaits for already-started agents and does not launch them.Changes
lib/project.sh,launch.sh,dashboard.sh,harvest.sh,costs.sh,progress.sh,tests/test.sh: share a Docker-safe internal project id while preserving raw repo names for display/run context.dashboard.sh,tests/test_dashboard.sh: render pendingPProws, addpfor post-process logs, and use confirmedPfor starting/replacing post-process.README.md,USAGE.md,launch.sh,tests/test_launch.sh: document thestartthenwaitflow and manual post-process/harvest behavior.CHANGELOG.md: add unreleased entries for the fixes.Test plan
./tests/test_dashboard.sh./tests/test_launch.sh./tests/test.sh --all