Skip to content

Fix formula support in Xlsx style#76

Open
Yugam18 wants to merge 4 commits intoprotobi:masterfrom
InTimeTecGitHub:master
Open

Fix formula support in Xlsx style#76
Yugam18 wants to merge 4 commits intoprotobi:masterfrom
InTimeTecGitHub:master

Conversation

@Yugam18
Copy link
Copy Markdown

@Yugam18 Yugam18 commented Jun 21, 2017

No description provided.

@protobi-pieter
Copy link
Copy Markdown
Collaborator

protobi-pieter commented Apr 19, 2018

@yugam This is a useful fix. We'll aim to incorporate this if we open the branch for new development. Generally for changes we need to make sure that:

  • changes are to the source code in the /bits/ directory rather than to xlsx.js (which is generated and overwritten by the make process)
  • add a unit test to verify this works
  • verify the test suite passes

suhli pushed a commit to suhli/node-xlsx that referenced this pull request Apr 24, 2021
Copy link
Copy Markdown

@ekossystem ekossystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyone can merge this code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants