Make the bin available to agents#3846
Conversation
Add .claude/skills/protomaker-cli.md so agents use the CLI (via Bash + --help discovery) as the primary board interface instead of MCP tools. Documents the full command surface and a feature->PR loop workflow. Co-authored-by: Automaker <automaker@localhost> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
* feat(docker): install beads_rust `br` CLI in the server image (#3835) Adds the `br` binary (Dicklesworthstone/beads_rust v0.2.11) alongside `gh` in the server runtime stage. SHA256-pinned, multi-arch (amd64 + arm64). Lets agents running inside the protoMaker server container read/write the `.beads/` issue-tracker store mounted from the host repo. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> * fix(docker): bump base from Bookworm to Trixie so the `br` binary loads (#3836) Follow-up to #3835. The `beads_rust` v0.2.11 amd64 binary is dynamically linked against GLIBC 2.38/2.39, but `node:22-slim` is Debian Bookworm (glibc 2.36) — running `br --version` in the built image fails with: br: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.38' not found br: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.39' not found `node:22-trixie-slim` ships glibc 2.41, which satisfies both. Trixie is Debian's current stable. All apt packages we install (gh, gosu, Playwright/Chromium deps, etc.) exist in Trixie. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> * docs: add CLI how-to guide and command reference Add a how-to walkthrough for driving the board from the CLI and a comprehensive reference covering all command groups and flags. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Co-authored-by: Automaker <automaker@localhost> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
|
Warning Review limit reached
More reviews will be available in 7 minutes and 13 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
QA Audit — PR #3846 | Make the bin available to agents
VERDICT: FAIL
CI Status
- deploy: queued
- test: queued
- build: queued
- checks: queued
Diff Review
PR adds a single skill documentation file (.claude/skills/protomaker-cli.md) — no binary, no build changes, no PATH integration.
Observations
-
CRITICAL / Acceptance Criteria Gap: The milestone states two ACs:
protomakerresolves in a fresh agent shell- documented how it gets on PATH
This PR only delivers AC 2 (documentation). There is no code, build, or packaging change that makes the actual
protomakerbinary resolvable on PATH. AC 1 is unmet. The PR title and milestone describe a binary availability problem; the diff is a documentation file. -
LOW: CI checks are all queued — no pass/fail signal yet. Blocked on CI in practice, but the structural gap above would warrant a request-changes regardless.
-
LOW: No tests. Acceptable for a docs-only addition.
Please either:
- Add the actual PATH/binary integration changes to fulfill AC 1, or
- Rephrase the milestone and ACs to accurately reflect that this is a documentation-only PR ("document the bin" vs. "make the bin available").
— Quinn, QA Engineer
|
Submitted |
|
This PR is a duplicate of #3844 which already covers the recovered work for the Diataxis docs feature (feature/agent-integration-diataxis-docs). The strand was caused by the git-workflow / AutoVerify not detecting committed-but-unpushed work — a bug tracked in #3845. Closing this duplicate; please use #3844 for review/merge. |
Summary
Milestone: Agent integration & docs
Ensure
protomakeris resolvable on PATH for agent/dev sessions (and the launch env), so agents can invoke it directly.Acceptance Criteria:
protomakerresolves in a fresh agent shellComplexity: small
Guardrails: If this phase involves new or changed behavior, include tests that verify correctness. If this phase adds, removes, or changes a user-facing feature, API endpoint, configuration option,...
Recovered automatically by Automaker post-agent hook