pr commands#3828
Merged
mabry1985 merged 6 commits intoMay 26, 2026
Merged
Conversation
…ops cleanup (#3802) * fix(auto-mode): worktrees by default + local antagonistic review + workflow default Stabilization fixes validated live this session: - auto-mode-service: useWorktrees defaults true in executeFeature/resumeFeature and the loop always dispatches with worktrees (was gated on executionMode != read-only). A stale 'read-only' executionMode previously let a scaffold agent run npm install in the main checkout and corrupt node_modules. Also adds 'config_corrupted' to the immediate-pause circuit breaker. - worktree-lifecycle-service: drop node_modules from BUILD_ARTIFACT_DIRS — each worktree runs its own npm ci and can no longer clobber the main install. - execution-service: run a local fresh-eyes (antagonistic) review of the staged worktree diff before the git-workflow/PR step; on BLOCK/CONCERN run one fix iteration. Fail-open, skips read-only. - project-orchestration-service: default phase workflow to 'standard' (was falling through fuzzy match-scoring into changelog-digest -> no PR). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * chore(ops): plugin cleanup + production launch script - plugin: repo URL automaker->protoMaker; CodeRabbit->Quinn in ava/setuplab; drop hardcoded /home/josh path from devops-health-check; README tool count; handle-mcp-failure.sh fallback uses ${AUTOMAKER_ROOT:-$PWD} not a hardcoded path. - scripts/launch-protomaker.sh: non-interactive prod build+serve for the macOS LaunchAgent (frees stale ports, sources .env, NODE_ENV=production). - tools/board_monitor.py: monitoring tweaks. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * style: prettier format setuplab.md Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * docs(auto-mode): document useWorktrees defaults to true Adds a Default column to the workflowSettings table; useWorktrees now true (see this PR's auto-mode-service change). Folds in the doc work from the 'Update docs after: protoMaker CLI' board feature. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(review): add timeout to local-review git execAsync calls Quinn review on #3802: git add -A / git diff --cached in the local fresh-eyes review had no timeout — a pathological worktree could hang the review step. Add a 120s guard (fail-open already catches it). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Automaker <automaker@localhost> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
…ows (#3812) deploy-docs.yml and deploy-site.yml interpolated ${{ github.event.head_commit.message }} directly into the wrangler `run:` block. A commit message with backticks / $() / ; is parsed by bash (CWE-94) — breaking the script and risking secret exfiltration in a job holding CLOUDFLARE_API_TOKEN. This already broke docs deploy on main (backticks in an agent commit body). Pass the message via an env var so the shell treats it as literal data. Co-authored-by: Automaker <automaker@localhost> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Add PR command group to the CLI with three subcommands: - pr create <featureId> opens a PR from a feature worktree - pr status <prNumber> shows CI rollup for a PR - pr merge <prNumber> merges with configured strategy Wired to /worktree/create-pr, /github/check-pr-status, and /github/merge-pr endpoints following existing command module patterns. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
Site preview: https://feature-core-board-commands-.automaker.pages.dev |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #3828 | pr commands
VERDICT: WARN
CI Status
- deploy-docs: in_progress
- deploy-site: in_progress
- checks: in_progress
- test: in_progress
- Close external code contributions: skipped
Diff Review
The PR contains three change clusters visible in the first 200 diff lines:
- Security fix (
.github/workflows/deploy-docs.yml,deploy-site.yml): Commit message now passed viaCOMMIT_MESSAGEenv var instead of direct shell interpolation — proper remediation of a potential command-injection path in a job holdingCLOUDFLARE_API_TOKEN. ✅ - useWorktrees default → true (
auto-mode-service.ts): Agents now always isolate to worktrees by default. Safer-by-default for a server that shares a checkout. ✅ - Local pre-PR review (
execution-service.ts): NewreviewAndIterateWorktreeDiffmethod runs an antagonistic fresh-eyes pass on the worktree diff before the git workflow commits/pushes/opens the PR (#3799). Fail-open design. ✅
Observations
- 🔴 TRUNCATED: Diff is 2155 lines; only the first 200 are visible. The PR title is "pr commands" and the milestone references
protomaker pr create|merge|statusCLI commands — none of that is visible in the sampled diff. Author should confirm the CLI implementation is included and tests cover it. - 🟡 CI in progress: All checks are still running. This review does not block merge pending passing CI.
- 🟢 Clawpatch unavailable (checkout cache error for
main/dev); LOW confidence reduction, not a gate. - 🟢 No CodeRabbit threads unresolved.
The three visible change clusters are all high-quality. The CI must pass and the title mismatch should be resolved before final approval.
— Quinn, QA Engineer
|
Submitted COMMENT review on |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Milestone: Core board commands
protomaker pr create <id>|merge <num>|status <num>over create_pr_from_worktree / merge_pr / check_pr_status endpoints.Acceptance Criteria:
Complexity: medium
Guardrails: If this phase involves new or changed behavior, include tests that verify correctness. If this phase adds, removes, or changes a user-facing f...
Created automatically by Automaker