Remove unnecessary setuptools dependency pin#332
Merged
rakeshwalisheter merged 3 commits intoprotectai:mainfrom Feb 18, 2026
Merged
Remove unnecessary setuptools dependency pin#332rakeshwalisheter merged 3 commits intoprotectai:mainfrom
rakeshwalisheter merged 3 commits intoprotectai:mainfrom
Conversation
setuptools is not imported anywhere in the modelscan source code and the build system uses poetry-core, so it is not needed as a declared dependency. The exact pin (80.9.0) was causing downstream dependency conflicts for consumers like model-security-client.
Member
|
Will note that's a pretty old version of |
rakeshwalisheter
previously approved these changes
Feb 18, 2026
Collaborator
rakeshwalisheter
left a comment
There was a problem hiding this comment.
lgtm. This pin was added to resolved a compliance P0 issue but can be removed now.
rakeshwalisheter
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setuptools = "80.9.0"pin frompyproject.tomlpoetry.lockto reflect the changeMotivation
setuptoolsis not imported anywhere in the modelscan source code and the build system usespoetry-core, so it is not needed as a declared runtime dependency. The exact pin propagates upstream to consumers and causes dependency conflicts for end users who have other packages with differentsetuptoolsversion requirements.Example error reported by customers:
setuptoolswill still be available transitively through other packages (e.g.,torch,tensorboard) that declare permissive version ranges — this change only removes the restrictive exact pin from modelscan itself.Testing
setuptoolsis not imported in any source file (grep -r "import setuptools\|from setuptools\|pkg_resources" modelscan/returns no results)poetry lockresolves successfully after the change