Skip to content

fix(core,cli): resolve workspace callees and fix flaky CI test#30

Merged
prosdev merged 1 commit into
mainfrom
fix/flaky-test-and-workspace-callees
Apr 1, 2026
Merged

fix(core,cli): resolve workspace callees and fix flaky CI test#30
prosdev merged 1 commit into
mainfrom
fix/flaky-test-and-workspace-callees

Conversation

@prosdev

@prosdev prosdev commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Resolve workspace package symlinks (pnpm links) to source paths in callee extraction — cross-package edges now appear in the dependency graph (33 → 114 edges)
  • Extract normalizeAndRelativize as a pure function for path normalization (dist/ → src/, .d.ts → .ts, absolute → relative)
  • Filter resolved paths still inside node_modules (prevents @types/node leaking into hot paths)
  • Bump flaky CI test timeout from 30s to 60s

Test plan

  • 7 new unit tests for normalizeAndRelativize (dist replacement, .d.ts, .js, multiple segments, relative, empty root, no-op)
  • Existing integration test verifies no absolute paths, no dist/, no .d.ts in callees
  • Full suite: 1711 passed, 39 skipped
  • Manual: dev refs "SearchAdapter" --depends-on "packages/core/src/services/search-service.ts" traces cross-package path

🤖 Generated with Claude Code

- Resolve workspace package symlinks to source paths in callee extraction.
  pnpm workspace links (node_modules/@scope/pkg → packages/pkg) are now
  followed via realpathSync, producing cross-package edges in the graph.
- Extract normalizeAndRelativize as a pure function for dist/ → src/,
  .d.ts → .ts, and absolute → relative path normalization.
- Filter resolved paths that are still inside node_modules (e.g. @types/node)
  to prevent external dependencies from appearing in hot paths.
- Bump flaky CI test timeout from 30s to 60s (ts-morph init is slow on
  GitHub runners).
- Clean up scratchpad: remove resolved flaky test entry.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@prosdev prosdev merged commit 4150c6d into main Apr 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant