fix: show module version for go install builds#17
Merged
Conversation
go install doesn't set ldflags, so Version stays empty. The fallback checked vcs.revision which go install also doesn't embed. Now checks info.Main.Version first, which go install does set to the module pseudo-version. Also: compress social-preview.png from 1.0M to 401K for GitHub upload. Assisted-By: Claude Opus 4
andresvio
force-pushed
the
fix/go-install-version
branch
from
efac6d6 to
e35ee50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go installusers: shows module pseudo-version instead of "dev"What was wrong
go installdoesn't set ldflags and doesn't embed VCS info. The fallback chain (ldflags → vcs.revision → "dev") always landed on "dev". Now checksinfo.Main.Versionfirst, whichgo installdoes populate.Test plan
go install ...@latestthentaskprim --versionshows a version, not "dev"make buildstill shows git describe versionAssisted-By: Claude Opus 4