feat(jangar): surface failure-domain lease holdbacks#5454
Conversation
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Marco release gate as of 2026-05-06T00:10Z: PR #5454 is merged and Jangar rollout-verified.
|
|
@codex review Retrying once after GitHub API quota recovered; merge remains blocked unless a Codex review is posted and all threads are resolved. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
bc14e09 to
e1a852c
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
e1a852c to
bc7d846
Compare
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
failure_domain_leasesto Jangar control-plane status, with typed per-domain leases, a lease-set digest, rollback targets, evidence refs, and per-action holdback decisions.docs/agents/designs/75-jangar-failure-domain-leases-and-database-routability-holdbacks-2026-05-05.md.generalNATS context selected the P0 launcher-admission gap governed bydocs/agents/designs/61-jangar-runtime-kits-and-admission-passports-contract-2026-03-20.mdand extended bydocs/agents/designs/65-jangar-recovery-warrants-and-runtime-proof-cells-contract-2026-03-21.md; that launcher gate landed in fix(jangar): gate swarm schedule runners by admission passport #5444, and this PR carries the next accepted runtime evidence surface for failure-domain holdbacks.Related Issues
None
Testing
bun install --frozen-lockfile --ignore-scriptsbun run test -- src/server/__tests__/supporting-primitives-controller.test.ts src/server/__tests__/control-plane-runtime-admission.test.ts src/server/__tests__/control-plane-status.test.ts src/server/__tests__/control-plane-failure-domain-leases.test.ts src/components/__tests__/agents-control-plane-status.test.tsx src/server/__tests__/kube-gateway.test.tsfromservices/jangar(6 files, 87 tests)bun run lintfromservices/jangarbunx tsc --noEmit --project tsconfig.paths.jsonfromservices/jangarbun run docs:inventory:checkfromservices/jangarbun run lint:oxlintfromservices/jangar(0 errors; 85 existing warnings)bun run lint:oxlint:typefromservices/jangar(0 errors; 284 existing warnings)bun run check:module-sizesfromservices/jangarbun run buildfromservices/jangargit diff --check origin/main...HEADgh pr checks 5454 --repo proompteng/lab --watchon headbc7d84624e5f9336d4d17b9b27a56b67865ec42djangar-ci / lint-and-typecheck / runagents-ci / validateagents-ci / integration(rerun passed in 29m1s after the first attempt was canceled while stuck without logs in local image build/preload)Lint commit messagesScreenshots (if applicable)
N/A. Status UI rendering is covered by
services/jangar/src/components/__tests__/agents-control-plane-status.test.tsx.Breaking Changes
None. The lease set is additive and
mode="shadow"; no AgentRun admission or deploy widening enforcement changes in this PR.Risk, Rollback, and Handoff
lease_set_digest, per-action holdbacks, and reason codes for deployer evidence.a4c52389366f74e58e0adfaa68be2e2c70e0dbabor ignorefailure_domain_leases; because enforcement is not enabled, rollback does not require deleting evidence or changing admission paths.JANGAR_SWARM_RUNTIME_ADMISSION_ENFORCEMENT=falseto return launcher admission to advisory mode while preserving passport projections.a4c52389366f74e58e0adfaa68be2e2c70e0dbabafter required/visible checks were green.Checklist