Skip to content

feat: allow override metrics configuration absolute path#191

Closed
kejrak wants to merge 5 commits into
promitor:mainfrom
kejrak:feat/190
Closed

feat: allow override metrics configuration absolute path#191
kejrak wants to merge 5 commits into
promitor:mainfrom
kejrak:feat/190

Conversation

@kejrak
Copy link
Copy Markdown

@kejrak kejrak commented Sep 3, 2025

Fixes #190

Thank you for review @tomkerkhove in advance.

@kejrak kejrak requested a review from tomkerkhove as a code owner September 3, 2025 10:36
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 3, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

@tomkerkhove tomkerkhove changed the title feat(190): allow override metrics configuration absolute path feat: allow override metrics configuration absolute path Sep 5, 2025
@kejrak
Copy link
Copy Markdown
Author

kejrak commented Sep 5, 2025

Gimme a sec, I will add fix to values.yaml

@kejrak
Copy link
Copy Markdown
Author

kejrak commented Sep 5, 2025

Should be good now. @tomkerkhove
I must say, very nice tool.

@kejrak kejrak requested a review from tomkerkhove September 5, 2025 16:19
@tomkerkhove
Copy link
Copy Markdown
Member

Sadly it looks like the configuration is not properly loaded, can you please check?

@kejrak
Copy link
Copy Markdown
Author

kejrak commented Sep 5, 2025

@tomkerkhove I have a quote for path, it seemed that this was the issue. Can you try to run the Workflow once more?

@kejrak
Copy link
Copy Markdown
Author

kejrak commented Sep 5, 2025

@tomkerkhove I see the issue.

In the last successful run, the Helm Template job correctly passed the values:

Run helm template promitor-agent-scraper ./promitor-agent-scraper/ --set azureAuthentication.identity.id=*** --set azureAuthentication.identity.key=*** --set azureMetadata.tenantId=*** --set azureMetadata.subscriptionId=*** --values ./config/scraper.yaml

But in the failing run, those parameters were present but empty:

Run helm template promitor-agent-scraper ./promitor-agent-scraper/ --set azureAuthentication.identity.id= --set azureAuthentication.identity.key= --set azureMetadata.tenantId= --set azureMetadata.subscriptionId= --values ./config/scraper.yaml

Do you have any idea why?

@kejrak
Copy link
Copy Markdown
Author

kejrak commented Sep 19, 2025

Any news @tomkerkhove?

@kejrak
Copy link
Copy Markdown
Author

kejrak commented Oct 7, 2025

Hi @tomkerkhove. I am just checking about any update.
Thanks a lot.

@tomkerkhove
Copy link
Copy Markdown
Member

@tomkerkhove I see the issue.

In the last successful run, the Helm Template job correctly passed the values:

Run helm template promitor-agent-scraper ./promitor-agent-scraper/ --set azureAuthentication.identity.id=*** --set azureAuthentication.identity.key=*** --set azureMetadata.tenantId=*** --set azureMetadata.subscriptionId=*** --values ./config/scraper.yaml

But in the failing run, those parameters were present but empty:

Run helm template promitor-agent-scraper ./promitor-agent-scraper/ --set azureAuthentication.identity.id= --set azureAuthentication.identity.key= --set azureMetadata.tenantId= --set azureMetadata.subscriptionId= --values ./config/scraper.yaml

Do you have any idea why?

Can you clarify which jobs you mean with links please?

@kejrak
Copy link
Copy Markdown
Author

kejrak commented Oct 9, 2025

Hi @tomkerkhove, every job (example https://github.com/promitor/charts/actions/runs/17504429558/job/49726192221?pr=191) at step Template Helm Chart has empty values.

Like this job https://github.com/promitor/charts/actions/runs/16875253075/job/47798213957, the values are correctly passed.

This might be a problem.

@kejrak
Copy link
Copy Markdown
Author

kejrak commented Dec 3, 2025

Hey @tomkerkhove. Any new updates?

@kejrak kejrak closed this by deleting the head repository Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Probably Issue with Metric Configuration

3 participants