feat: allow override metrics configuration absolute path#191
Conversation
|
Gimme a sec, I will add fix to values.yaml |
|
Should be good now. @tomkerkhove |
|
Sadly it looks like the configuration is not properly loaded, can you please check? |
|
@tomkerkhove I have a quote for path, it seemed that this was the issue. Can you try to run the Workflow once more? |
|
@tomkerkhove I see the issue. In the last successful run, the Helm Template job correctly passed the values: Run helm template promitor-agent-scraper ./promitor-agent-scraper/ --set azureAuthentication.identity.id=*** --set azureAuthentication.identity.key=*** --set azureMetadata.tenantId=*** --set azureMetadata.subscriptionId=*** --values ./config/scraper.yaml But in the failing run, those parameters were present but empty: Run helm template promitor-agent-scraper ./promitor-agent-scraper/ --set azureAuthentication.identity.id= --set azureAuthentication.identity.key= --set azureMetadata.tenantId= --set azureMetadata.subscriptionId= --values ./config/scraper.yaml Do you have any idea why? |
|
Any news @tomkerkhove? |
|
Hi @tomkerkhove. I am just checking about any update. |
Can you clarify which jobs you mean with links please? |
|
Hi @tomkerkhove, every job (example https://github.com/promitor/charts/actions/runs/17504429558/job/49726192221?pr=191) at step Template Helm Chart has empty values. Like this job https://github.com/promitor/charts/actions/runs/16875253075/job/47798213957, the values are correctly passed. This might be a problem. |
|
Hey @tomkerkhove. Any new updates? |
Fixes #190
Thank you for review @tomkerkhove in advance.