Skip to content

Conversation

@jj-asama
Copy link
Contributor

Fixes #761

Also makes the error messages more verbose.

Signed-off-by: Jain Johny <jj@asama.ai>
Signed-off-by: Jain Johny <jj@asama.ai>
Signed-off-by: Jain Johny <jj@asama.ai>

case "sriov_vf_device":
value, err := strconv.ParseUint(valueStr, 10, 32)
value, err := strconv.ParseUint(valueStr, 16, 32)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperQ this fixes #761 . Value in this file doesn't have 0x prefix which led to the mistake.

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ changed the title Use base16 to convert pci sriov_vf_device Fix: Use base16 to convert pci sriov_vf_device Oct 30, 2025
@SuperQ SuperQ merged commit 9b0219b into prometheus:master Oct 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error obtaining PCI device info

2 participants