Skip to content

Store and use archived filename in the bin directory #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rapphil wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Store and use archived filename in the bin directory #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion remote_write_sender/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ The repo tests the following remote write senders:
- The [VictoriaMetrics Agent](https://github.com/VictoriaMetrics/VictoriaMetrics/tree/master/app/vmagent), unless you're on [Mac OS X](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1042).
- [Timber.io Vector](https://github.com/timberio/vector).

If you want to test a dev version of your sender, simply put your binary in `bin/`.
If you want to test a dev version of your sender, simply put your binary in `bin/` using the same name of the binary that is in the published artifact.

Example: for OpenTelemetry collector, the published artifact is `otelcol_0.42.0_linux_amd64.tar.gz` and the binary inside of it is `otelcol`.

To add another sender, see the examples in [the targets director](targets/) and recreate that pattern in a PR.
14 changes: 4 additions & 10 deletions remote_write_sender/targets/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,10 @@ func downloadBinaryUnlocked(urlPattern string, filenameInArchivePattern string)
return "", err
}

filename := path.Join(cwd, "bin", path.Base(parsed.Path))
decompressTgz := strings.HasSuffix(filename, ".tar.gz")
if decompressTgz {
filename = strings.TrimSuffix(filename, ".tar.gz")
}

decompressZip := strings.HasSuffix(filename, ".zip")
if decompressZip {
filename = strings.TrimSuffix(filename, ".zip")
}
filename := path.Join(cwd, "bin", filenameInArchive)
publishedArtifactName := path.Base(parsed.Path)
decompressTgz := strings.HasSuffix(publishedArtifactName, ".tar.gz")
decompressZip := strings.HasSuffix(publishedArtifactName, ".zip")

// If we've already downloaded it, then skip.
if _, err := os.Stat(filename); !os.IsNotExist(err) {
Expand Down